[D-runtime] druntime fixes again break Windows DLL support

Rainer Schuetze r.sagitario at gmx.de
Fri Apr 22 12:41:22 PDT 2011


Sean Kelly wrote:
> On Apr 22, 2011, at 11:09 AM, Sean Kelly wrote:
> 
>> On Apr 22, 2011, at 9:48 AM, Rainer Schuetze wrote:
>>
>>> Rainer Schuetze wrote:
>>>> Recently, I also started creating threads in a DLL, and that revealed a few inconsistencies between dll_helper.d and thread.d. The major problem is that DLLMain is called before the thread is added to the list of library created threads, causing initialization to be done twice.
>>>> I have a patch for this, but I'm not yet on the latest git-version. I'll try to update the bugzilla entry http://d.puremagic.com/issues/show_bug.cgi?id=5582 with it and maybe even create a pull request.
>>> here's the commit with my patches to the runtime regarding DLL support for Windows Server 2003 and XP/64 and thread creation inside a DLL:
>>>
>>> https://github.com/rainers/druntime/commit/864bb10cab2e0a3807df27962a73990b9e44c1e1
>> Awesome.  I'll apply it today.
> 
> Oops... could you create a pull request?

Tried my best here:

https://github.com/D-Programming-Language/druntime/pull/12

but it contains commits you'd probably do not want. I guess you'll have 
to "cherry pick" the commit that corresponds to the commit shown above.

Is there any sensible way to create a pull request from single commits? 
I don't want to create branches for every single change, especially if 
the building/working with the library need other changes aswell. Keeping 
changes locally does not work either, because git refuses to pull 
updates from other sources then.


More information about the D-runtime mailing list