[D-runtime] [D-Programming-Language/druntime] 850eaa: Do not sort arrays of immutable elements, use a ca...

Brad Roberts braddr at puremagic.com
Tue Jul 12 16:02:25 PDT 2011


On Tue, 12 Jul 2011, Michel Fortin wrote:

> Le 2011-07-12 ? 14:26, Jonathan M Davis a ?crit :
> 
> > On 2011-07-12 10:00, Brad Roberts wrote:
> >> Yay.. first post-release checkin, and the build breakage is in full swing.
> >> 
> >> :)
> > 
> > *Sigh* And it was so nice to see it all green. I was even considering 
> > commenting on how wonderful it was that the autotester was all green for once. 
> > We really should do a better job of avoiding breakages...
> 
> I think it'd help a lot if it was possible to request a specific commit to be tested by the autotester. I develop on OS X and it's hard for me to check that something works on other platforms. In my latest DMD pull request (Type-checked arrays) I asked if other people could test on other platforms... which isn't really nice at the stage of a pull request. Being able to request a test run on this (and having the error log) would make me able to fix problems for all platforms by myself before even creating a pull request.
> 
> Perhaps we should have a web form to enqueue a test run like that:
> 
> User: michelf
> DMD Commit: 000000
> Druntime Commit: 000000
> Phobos Commit: 000000
> 
> This would enqueue a request to fetch michelf's github repository for dmd, druntime, and phobos, checkout specific commit for each repo and then run the tests.

There's value in it, yes.  There's also significant security risk in it 
that I'm not comfortable with nor eager to invest the time to reduce.  
Yes, I recognize that there's risk even with the current system, but less 
as there's far more eyeballs on the main source tree.  I'm ok with things 
breaking from time to time, it happens.  I'm mostly interested in reacting 
appropriately when it does.

If anyone else wants to volunteer their time and systems to running an 
adhoc tester like the above, please do so.  Keep in mind that the systems 
I'm running are my donated time and money (with a nod to Sean for the 
contribution of an account on an osx box).

Also, not that I'm picking on today's commit, since it's not the first 
time it's happened, but commits that fail on _every_ platform just 
shouldn't happen.

My 2 cents,
Brad



More information about the D-runtime mailing list