[D-runtime] [D-Programming-Language/druntime] 36736e: Fix 11761: aa.byKey and aa.byValue are not forward...

GitHub via D-runtime d-runtime at puremagic.com
Fri Aug 15 01:52:50 PDT 2014


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/druntime
  Commit: 36736e430b0c5299cf2ab9875be3b36236185f3b
      https://github.com/D-Programming-Language/druntime/commit/36736e430b0c5299cf2ab9875be3b36236185f3b
  Author: H. S. Teoh <hsteoh at quickfur.ath.cx>
  Date:   2014-08-14 (Thu, 14 Aug 2014)

  Changed paths:
    M src/object.di
    M src/object_.d

  Log Message:
  -----------
  Fix 11761: aa.byKey and aa.byValue are not forward ranges.

The problem is that Phobos' `isForwardRange` template requires that
`.save` must be `@property`, otherwise it does not acknowledge the range
as a forward range; however, aa.byKey and aa.byValue's `.save` weren't
marked as such. This PR fixes this problem and introduces a unittest to
ensure the forward range criteria are satisfied.


  Commit: af3d9ec84620d892ce22a91c31770256e38e2d33
      https://github.com/D-Programming-Language/druntime/commit/af3d9ec84620d892ce22a91c31770256e38e2d33
  Author: H. S. Teoh <hsteoh at quickfur.ath.cx>
  Date:   2014-08-14 (Thu, 14 Aug 2014)

  Changed paths:
    M src/object_.d

  Log Message:
  -----------
  DRY up the unittest.


  Commit: 38eee4cdf371ca9ab49962d2dfadbfb5785d7bcb
      https://github.com/D-Programming-Language/druntime/commit/38eee4cdf371ca9ab49962d2dfadbfb5785d7bcb
  Author: Hara Kenji <k.hara.pg+dev at gmail.com>
  Date:   2014-08-15 (Fri, 15 Aug 2014)

  Changed paths:
    M src/object.di
    M src/object_.d

  Log Message:
  -----------
  Merge pull request #925 from quickfur/issue11761

Fix 11761: aa.byKey and aa.byValue are not forward ranges.


Compare: https://github.com/D-Programming-Language/druntime/compare/18462233596d...38eee4cdf371


More information about the D-runtime mailing list