[Issue 314] [module] Static, renamed, and selective imports are always public

[d-bugmail at puremagic.com]

http://d.puremagic.com/issues/show_bug.cgi?id=314



--- Comment #20 from Don <clugdbug at yahoo.com.au> 2010-08-12 01:04:26 PDT ---
(In reply to comment #19)
> Don, which version of the patch did you apply - the one attached here or the
> one I applied to LDC? Selective imports work correctly in LDC, so maybe there's
> some extra work needed for D2. I also expect the patch to require some work
> with regard to overload resolution, it works differently in D2.

The one attached here. Although I've found some problems with selective
imports, I no longer think they are the fault of this patch. For example, the
existing release of D1 doesn't like this example:
---
import std.stdio : writefln;
void main() {
   std.stdio.writefln("xyz");
}

test0.d(338): Error: undefined identifier std
Error: no property 'writefln' for type 'TOK149'
test0.d(338): Error: function expected before (), not __error of type TOK149
---
After applying the patch and my change to Id::object, and fixing a bug in each
of druntime, Phobos, and the test suite, all Phobos unittests pass, and the DMD
test suite passes all tests. Looks great to me.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------