[Issue 3986] Struct constructors bypass default initialization of member variables

[d-bugmail at puremagic.com]

http://d.puremagic.com/issues/show_bug.cgi?id=3986


Don <clugdbug at yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


--- Comment #1 from Don <clugdbug at yahoo.com.au> 2010-03-20 00:26:22 PDT ---
PATCH: In VarDeclaration::semantic, it should be doing a blit of the default
initializer before it calls the constructor.
Currently it only does that for explicit constructor calls.
This bug as a blocker, since it makes struct invariants unusable: if a struct
with a class invariant is used as a member of another struct, the invariant
will fail on first use of that struct.


Index: declaration.c
===================================================================
--- declaration.c    (revision 418)
+++ declaration.c    (working copy)
@@ -1139,6 +1139,14 @@
                // Rewrite as e1.ctor(arguments)
                 Expression *ector = new DotIdExp(loc, e1, Id::ctor);
                 ei->exp = new CallExp(loc, ector, ei->exp);
+                /* Before calling the constructor, initialize
+                 * variable with a bit copy of the default
+                 * initializer
+                 */
+                Expression *e = new AssignExp(loc, e1, t->defaultInit(loc));
+                e->op = TOKblit;
+                e->type = t;
+                ei->exp = new CommaExp(loc, e, ei->exp);
             } 
             else
             /* Look for opCall

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------