[Issue 5505] New: std.functional: Fix for possible lurking bug & replace complex return type with auto

[d-bugmail at puremagic.com]

http://d.puremagic.com/issues/show_bug.cgi?id=5505

           Summary: std.functional: Fix for possible lurking bug & replace
                    complex return type with auto
           Product: D
           Version: D2
          Platform: Other
        OS/Version: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Phobos
        AssignedTo: nobody at puremagic.com
        ReportedBy: andrej.mitrovich at gmail.com


--- Comment #0 from Andrej Mitrovic <andrej.mitrovich at gmail.com> 2011-01-29 16:23:06 PST ---
In DMD 2.051, std.functional, line 53:
enum testAsStmts = "{"~ElementType.stringof~" "~parmName~"; "~fun~"}()";

I think the line is missing a semicolon after "~fun~". Fixed:
enum testAsStmts = "{"~ElementType.stringof~" "~parmName~"; "~fun~";}()";

But the code that uses the enum is commented out for some reason.

Line 250, binaryReverseArgs:

Why not replace this complex return type:
    typeof({ ElementType1 a; ElementType2 b; return pred(b, a);}())
    binaryReverseArgs(ElementType1, ElementType2)(ElementType1 a,
            ElementType2 b)
    {
        return pred(b, a);
    }

with the simpler:
    auto binaryReverseArgs(ElementType1, ElementType2)(ElementType1 a,
            ElementType2 b)
    {
        return pred(b, a);
    }

unittests will still pass.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------