[Issue 7067] std.random.RandomSample and RandomCover are poorly designed

d-bugmail at puremagic.com d-bugmail at puremagic.com
Wed Aug 21 07:38:16 PDT 2013


http://d.puremagic.com/issues/show_bug.cgi?id=7067



--- Comment #17 from Joseph Rushton Wakeling <joseph.wakeling at webdrake.net> 2013-08-21 07:38:13 PDT ---
(In reply to comment #14)
> What we can do, though, is to salvage things minimally by patching RandomCover
> to use the same technique as RandomSample -- that is, if the constructor gets
> passed an RNG, copy it; but if not -- call rndGen directly.  I'm going to
> prepare some patches to that effect, which will also try and do something about
> the .save methods of Random{Cover,Sample} -- both of which are currently
> broken.

Just to note, I've submitted a pull request with updates along these lines:
https://github.com/D-Programming-Language/phobos/pull/1499

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------


More information about the Digitalmars-d-bugs mailing list