[Issue 10862] Assignment inside if condition still sometimes accepted

[d-bugmail at puremagic.com]

http://d.puremagic.com/issues/show_bug.cgi?id=10862



--- Comment #14 from Jonathan M Davis <jmdavisProg at gmx.com> 2013-08-21 10:54:30 PDT ---
Sure, it's just one space, but I also see no reason whatsoever to have it. It
adds zero value IMHO. There are other places where I may think that extra
spaces may be worth it, and you may not. I happen to value lining up arguments
far more than saving space. I also typically don't mind using extra vertical
space, whereas others really don't like it. And I'm not about to claim that the
formatting in std.datetime is perfect or couldn't be improved, but whatever I
did with it seemed reasonable to me at the time. Different people have
different opinions on what improves or harms legibility and what is good and
bad formatting. For the most part, it's very subjective.

Personally, I happen to see no value in putting a space after the if, whereas
you and Andrei like it. I don't think that you can objectively say that one is
better than the other. Other people would be arguing that no space should go
there but that spaces should be put inside the parens. It's all personal
preference, and arguing about it doesn't get us anywhere.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------