[Issue 14125] @trusted nested helper functions in std.file

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=14125

--- Comment #72 from Andrei Alexandrescu <andrei at erdani.com> ---
(In reply to hsteoh from comment #68)
> Then there's Andrei's PR that contains a 50+-line @trusted function. I had a
> headache trying to figure out whether it was truly @trusted -- it's wayyyy
> too big to be adequately reviewed in a satisfactory way.

50 lines is very little code, and code that interfaces with low-level libraries
and optimizes the bejesus out of system calls and memory allocations -
obviously there must be some manual verification going on, and I don't see it
as onerous.

It also replaces code that is in no way more provably safe because it uses
escape hatches literally almost at every line! How is that drivel better when
it has functions that allow escaping addresses and adding pointers and all that
stuff?

I am sorry I am not buying this line of argumentation for one second.
https://github.com/D-Programming-Language/phobos/pull/2963 replaces utter
drivel with sensible code.

--