[Issue 21825] DIP1034: Do not spuriously warn "calling XXX without side effects discards return value of type 'noreturn'"

[d-bugmail at puremagic.com]

https://issues.dlang.org/show_bug.cgi?id=21825

Dlang Bot <dlang-bot at dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #1 from Dlang Bot <dlang-bot at dlang.rocks> ---
@n8sh updated dlang/dmd pull request #12430 "DIP1034: make lambdaHasSideEffect
true for noreturn functions" fixing this issue:

- Fix issue 21825 - DIP1034: make lambdaHasSideEffect true for noreturn
functions

  Prevents spurious warning "calling XXX without side effects discards
  return value of type `noreturn`; prepend a `cast(void)` if intentional".

  Also changes the result of hasSideEffect and behavior of isTrivialExp.

  There appears to be a general inconsistency where a function that
  performs side-effectful operations may be considered side-effectless
  but if that is indeed a problem addressing it is beyond the scope of
  this PR.

https://github.com/dlang/dmd/pull/12430

--