[Issue 21590] assignment inside assert accepted if -checkaction=context is given

[d-bugmail at puremagic.com]

https://issues.dlang.org/show_bug.cgi?id=21590

Dlang Bot <dlang-bot at dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #2 from Dlang Bot <dlang-bot at dlang.rocks> ---
@MoonlightSentinel created dlang/dmd pull request #12165 "Fix 21590 -
assignment inside assert accepted for -checkaction=context" fixing this issue:

- Fix 21590 - assignment inside assert accepted for -checkaction=context

  The rewrite introduced a temporary which hid the assignment inside of
  `assert(...)` and hence prevented the error.

  The fix is to omit the additional temporary for `AssignExp` and use
  the assigned variable directly. The temporary is unecessary anyways
  and the following semantic analysis will raise an appropriate error.

https://github.com/dlang/dmd/pull/12165

--