[Issue 23152] Bad diagnostic for variable used as a type

[d-bugmail at puremagic.com]

https://issues.dlang.org/show_bug.cgi?id=23152

Iain Buclaw <ibuclaw at gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ibuclaw at gdcproject.org

--- Comment #2 from Iain Buclaw <ibuclaw at gdcproject.org> ---
Looks like https://github.com/dlang/dmd/pull/5588 introduced the loss of "S2 is
used as a type" diagnostic.


In particular this change switched the result of resolving the identifier from
an error expression to an error type (the latter doesn't have a "used as a
type" follow-up error).

https://github.com/dlang/dmd/pull/5588/files#diff-17f8386682e9c4681f8080c09449e8db528014e83496ce7ed72fc82001fd0883R7455-R7460

--