[Issue 23883] `#line` is off by one and off by two if a line comment follows

d-bugmail at puremagic.com d-bugmail at puremagic.com
Thu May 11 13:57:31 UTC 2023


https://issues.dlang.org/show_bug.cgi?id=23883

RazvanN <razvan.nitu1305 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

--- Comment #3 from RazvanN <razvan.nitu1305 at gmail.com> ---
(In reply to Bolpat from comment #2)
> So, you’re suggesting that we make a bug a feature. Checking for comments
> before the directive ends isn’t that big of a deal.
> 

No, I am saying that this is such niche case (why would you attach comments to
line directives?) that it doesn't really warrant the complexity added in the
lexer.

But I understand your point of view, that's why I'm leaving this bug report
open.

> You don’t even have to handle it correctly, you can make it an error if that
> is easier. It’s surprising, and you shouldn’t surprise users.

--


More information about the Digitalmars-d-bugs mailing list