[Issue 24366] [REG]static foreach can drop last element with alias reassignment

[d-bugmail at puremagic.com]

https://issues.dlang.org/show_bug.cgi?id=24366

Adam D. Ruppe <destructionator at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |destructionator at gmail.com

--- Comment #1 from Adam D. Ruppe <destructionator at gmail.com> ---
We identified the cause in OpenD as dsymbolsem.d look for "Try AliasSeq
optimization"

Commenting that out fixes the problem.

    // Try AliasSeq optimization
    /+
    // actually don't because it is cause of
https://issues.dlang.org/show_bug.cgi?id=24366
    if (auto ti = ds.type.isTypeInstance())
    {
        if (!ti.tempinst.findTempDecl(sc, null))
            return errorRet();
        if (auto tempinst = isAliasSeq(sc, ti))
        {
            s = aliasAssignInPlace(sc, tempinst, aliassym);
            if (!s)
                return errorRet();
            goto Lsymdone;
        }
    }
    +/

--