github: What to do when unittests fail?

Dmitry Olshansky dmitry.olsh at gmail.com
Mon May 23 15:01:21 PDT 2011


On 24.05.2011 1:33, Andrej Mitrovic wrote:
> I've cloned Phobos just a few minutes ago, and I've tried to build it with unittests, I'm getting these:
>
> Warning: AutoImplement!(C_6) ignored variadic arguments to the constructor C_6(...)
>   --- std.socket(316) broken test ---
>   --- std.regex(3671) broken test ---

Windows build is polluted by these messages that meant something 
sometime ago (usually there was a test that failed, and it was commented 
out for now).
Still it builds quite easily, though I skipped a couple of recent commits.

> So what's the procedure now? Do I have to first revert to some earlier version of Phobos that has unittests that pass, before doing any edits? I want to edit an unrelated module and change some code (actually change a unittest), and make a pull request. This is for an already reported bug in bugzilla.
Check auto-tester first ;)
http://d.puremagic.com/test-results/

-- 
Dmitry Olshansky



More information about the Digitalmars-d-learn mailing list