github: What to do when unittests fail?

Andrej Mitrovic andrej.mitrovich at gmail.com
Tue May 24 11:45:12 PDT 2011


Hmm I've gotten into some trouble. I've made a pull request for my
first fix from a new branch:
https://github.com/D-Programming-Language/phobos/pull/56

Then I wanted to do another fix so I created a new branch, made the
fix, pushed to my phobos fork on github. Then I did a pull request
from this new branch, but in the new pull request it also showed two
commits, the new one and the older one from the previous pull request.

Should I have made multiple commits for each fix and do only a single
pull request?


More information about the Digitalmars-d-learn mailing list