BitArray/BitFields - Review

[H. S. Teoh via Digitalmars-d-learn]

On Thu, Aug 07, 2014 at 02:04:12AM +0000, Era Scarecrow via Digitalmars-d-learn wrote:
> On Thursday, 7 August 2014 at 01:51:46 UTC, H. S. Teoh via
> Digitalmars-d-learn wrote:
> >Since this is about contributing to Phobos, probably a better place to ask
> >is on the main D forum.
> 
>  Yeah posted in my 'what have i missed?' as well...
> 
> >Do you have a pull request? Which one is it?
> 
> https://github.com/rtcvb32/phobos/pull/1
> 
> From the looks of things it's 4 commits that are merged into a single
> request i think...

Hold on a sec... that's a pull for your own fork of Phobos. You need to
submit a pull to the main Phobos repo in order to get it reviewed and
merged. :-)


> >There have been a few fixes to std.bitmanip recently, including a
> >current PR for adding attributes to some of the functions. Are these
> >your PRs, or are you proposing something totally new? If it's
> >something totally new, where can we get the code?
> 
> Glancing at the current code, none of my stuff got in. I do a large
> number of fixes, so likely a lot of those changes would get thrown
> away or integrated...
[...]

Well, no wonder, your pull was submitted against your local fork, not to
the main Phobos repo, so nobody knew about it (except Dmitry,
apparently). It would help to submit pulls against the main Phobos repo.
:-)

Also, looks like you made major changes to the code... if it's a
complete rewrite, I'd say submit it as a single pull. If it's a
collection of many fixes, it's probably better to submit separate pulls
so that the easy fixes will get in first while we work out the wrinkles
on the more complicated fixes.


T

-- 
Любишь кататься - люби и саночки возить.