Humble request at Walter: Could you _please_ fix phobos already?
TomD
t_demmer at NOSPAM.web.de
Mon Jul 23 21:19:39 PDT 2007
Walter Bright Wrote:
[...]
>
> A good patch has the following attributes:
>
> 1) It's done based on a good understanding of how the module works and
> how it should work.
>
> 2) It's been tried and found to work. Saying it "seems" to work isn't
> good enough, and leaves me with the thought that the engineering of the
> patch will have to be completely redone.
>
> 3) Unit tests are included to independently verify that it does, indeed,
> work and solve the bug.
>
> 4) The -cov switch was used to verify that all lines of the patch were
> executed by the unit tests.
>
> Do I consistently live up to this standard 100%? Nope, and shame on me
> for not. And every time I don't, I get burned.
Fair enough. Maybe these guidelines should be put somewhere prominently
on the bugs&issues area. (3) and especially (4) slipped my mind.
Ciao
Tom
More information about the Digitalmars-d
mailing list