Give me a break

Walter Bright newshound1 at digitalmars.com
Thu Jul 2 11:35:32 PDT 2009


Tom S wrote:
> Guilty as charged. Sorry about that. I didn't consider the case where 
> someone would not provide a file name and didn't realize that write 
> errors were an issue in this case. I guess I'm used to I/O code throwing 
> exceptions when something goes wrong ;)
> 
> The MAX_PATH+2 was probably plain stupid of me. I wanted to hardcode it 
> to '256' but then thought 'oh, MAX_PATH+2 would be better!', both of 
> which were braindead considering that I've just checked that filename 
> ops in DMD use dynamic allocation for this purpose. Please let me know 
> the next time I commit a crime like this and I'll fix it gladly! I 
> promise my next patch will be better :P

I wouldn't worry about it. We all make mistakes programming - that's 
what code reviews are for.


> Thanks for folding it in! *g*




More information about the Digitalmars-d mailing list