etc.curl: Formal review begin

Jonas Drewsen jdrewsen at nospam.com
Thu Aug 25 03:09:08 PDT 2011


On 24/08/11 16.34, Johannes Pfau wrote:
> Damn, I forgot the most important part:
>
> etc.curl currently uses none of D's "advanced" function attributes.
> This means that etc.curl can't be used in safeD for example. IMHO
> that's a big problem: New phobos code should be usable in safeD it's
> bad enough that lots of old code isn't.
>
> So:
> @safe or @trusted needs to be added to almost all functions in etc.curl.
ok

> 'const' (as in const functions, not const arguments) probably doesn't
> make sense for a wrapper, so that's not needed.
>
> There are some functions which could be 'pure': escape&  unescape for
> example

Actually libcurl just recently changed their escape API to require a 
curl handle. This means we cannot make it pure I guess.

> Seems like most functions can throw, but maybe some are 'nothrow'.

Will check.



More information about the Digitalmars-d mailing list