Curl wrapper review

[Jonas Drewsen]

On 17/11/11 11.54, Jacob Carlborg wrote:
> On 2011-11-17 10:16, Jonas Drewsen wrote:
>> On 16/11/11 20.21, Johannes Pfau wrote:
>>> Jonas Drewsen wrote:
>>>> Hi,
>>>>
>>>> After all the comments from last review I've refactored the curl
>>>> wrapper and it is ready for a new review.
>>>>
>>>> David Nadlinger was handling the last review so I guess it would make
>>>> sense if he run this one as well if he wants to.
>>>>
>>>> Code:
>>>> https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d
>>>>
>>>> Docs:
>>>> http://freeze.steamwinter.com/D/web/phobos/etc_curl.html
>>>>
>>>> Regards,
>>>> Jonas
>>>
>>> Looks great so far!
>>>
>>> Some minor nitpicks:
>>>
>>> * Examples: "new Http()" is used 4 times in the examples, but as Http is
>>> a struct, I see no reason to create it using new?
>>
>> new Http() calls opCall() where a bunch of stuff is initialized.
>
> As far as I know "new Http()" does not call opCall, at least not the
> static one. Use this to call opCall:
>
> "auto http = Http()";
>

You're right of course.

/Jonas