Review of Jesse Phillips's CSV Parser
Jesse Phillips
jessekphillips+D at gmail.com
Fri Oct 28 08:31:47 PDT 2011
dsimcha Wrote:
> I'll kick this off with my review of the documentation (I'll review the
> implementation later):
>
> "Header may be provided as first line in file" -> "A header may be
> provided as first line in file"?
>
> csvText: Shouldn't heading be a generic range of strings instead of a
> string[]?
I should revisit that. It will still need to be random access and possible some others, but doesn't need to be an array.
> Why should the order of the heading provided to csvText matter? csvText
> should simply rearrange its results.
>
> In csvNextToken: "The expected use of this would be to create a parser.
> And may also be useful when handling errors within a CSV file." Please
> re-word this sentence so it's grammatically correct.
More information about the Digitalmars-d
mailing list