Review of Jesse Phillips's CSV Parser

[Walter Bright]

On 10/28/2011 6:18 AM, dsimcha wrote:
> Formal review of Jesse Phillips's CSV parser module begins today and runs
> through November . Following that, a vote will take place for one week. Please
> post any comments about this library in this thread.
>
> Docs:
> http://nascent.freeshell.org/programming/D/doc/phobos/std_csv.html
>
> Code:
> https://github.com/he-the-great/phobos/tree/csv

First off, mucho thanks to Jesse for writing this. It's an important module for 
Phobos.

This is a review of the documentation:

Include this link: http://en.wikipedia.org/wiki/Comma-separated_values so the 
programmer can learn more about CSV.

"This parser will loosely follow the RFC-4180"

How exactly will it differ from RFC-4180?

"No exceptions are thrown due to incorrect CSV."

What happens, then, when the CSV is incorrect?

"csvText"

Be more specific about what csvText() returns.

I'm confused about the heading parameter to csvText().

"the Content of the input"

What is that? There's no parameter named "Content".

"RecordList"

"Range which provides access to CSV Records and Fields."

What is the Range? Do you mean RecordList is a Range? And what does "provides 
access" mean? If RecordList is a Range, why is it labeled a "List"?

"Array of the heading contained in the file."

Now I'm really confused as to what a heading is. I thought it was the first 
line? Now there's an array of them?

No examples given for constructors.

No documentation for front() or empty().

"Record"

"Returned by a RecordList when Contents is a non-struct."

RecordList is a struct, it does not return anything.

No examples.

"csvNextToken"

Example?