std.benchmark is in reviewable state

Jonathan M Davis jmdavisProg at gmx.com
Mon Sep 26 20:12:14 PDT 2011


On Monday, September 26, 2011 20:09:37 Jonathan M Davis wrote:
> On Sunday, September 25, 2011 20:08:45 Andrei Alexandrescu wrote:
> > I've had a good time with std.benchmark today and made it ready for
> > submission to Phobos. As a perk I've added the %h format specifier,
> > which formats a number in human-readable form using SI prefixes.
> > 
> > For those interested in discussing this prior to the formal review
> > process, the code is at:
> > 
> > https://github.com/andralex/phobos/blob/benchmark/std/benchmark.d
> > https://github.com/andralex/phobos/blob/benchmark/std/format.d
> > 
> > and the dox at
> > 
> > http://erdani.com/d/web/phobos-prerelease/std_benchmark.html
> > http://erdani.com/d/web/phobos-prerelease/std_format.html
> > 
> > Comments and suggestions are welcome. If possible, it would be great if
> > this submission were given a bump in the priority queue. This is because
> > with robust benchmarking in Phobos we can ask new, performance-sensitive
> > submissions, to add benchmarking.
> 
> You might want to check the compilability of your code. I merged your
> benchmark branch into a branch that I just branched from master, and it
> fails to compile with the latest compiler.

That is, the unittest target fails to compile (due to a template error). The 
normal build succeeds (probably because it's not compiling the benchmark 
function - which is the templated function which is failing).

- Jonathan M Davis


More information about the Digitalmars-d mailing list