Standalone AA implementation ready for review (Was: Re: Replacing AA's in druntime)

[Steven Schveighoffer]

On Thu, 15 Mar 2012 06:19:33 -0400, Jacob Carlborg <doob at me.com> wrote:

> On 2012-03-15 08:59, foobar wrote:
>> On Wednesday, 14 March 2012 at 23:14:42 UTC, H. S. Teoh wrote:
>>> Alright, I've finished the basic functionality of my AA implementation.
>>> I still haven't solved that problem with using suffixless string
>>> literals to index X[dstring], so you'll have to write aa["abc"d]  
>>> instead
>>> of just aa["abc"]. But I thought I should post my code now so that
>>> people can take a look at it:
>>>
>>> https://github.com/quickfur/New-AA-implementation/blob/master/newAA.d
>>>
>>>
>>> T
>>
>> Thanks for tackling the AA problem.
>> I have one slight issue / comment regarding AAs: I really dislike the
>> idea of cramming everything under the sun into object.d. In general,
>> cramming lots'o'code into a single mega file is a code smell which
>> Phobos greatly stinks from.
>> At the very least, object.d can publicly import your newAA.d module
>> which gives the exact same outcome while keeping separate features
>> separate.
>
> I think object.d should be empty except for the definition of Object.  
> The rest should be located in their own modules and publicly imported in  
> object.d

I think the compiler would have to change for that to happen.

I would support such a change, but then again, it seems like we'd get  
little measurable benefit for it, making it difficult to get through  
Walter.

-Steve