code cleanup in druntime and phobos

[Iain Buclaw via Digitalmars-d]

On 30 Aug 2014 12:35, "Jonathan M Davis via Digitalmars-d" <
digitalmars-d at puremagic.com> wrote:
>
> On Saturday, 30 August 2014 at 10:57:51 UTC, ketmar via Digitalmars-d
wrote:
>>
>> Hello.
>>
>> there are some c-style array declarations both in druntime and in
>> phobos. i made two patches that fixes 'em:
>>
>>https://issues.dlang.org/show_bug.cgi?id=13401
>>https://issues.dlang.org/show_bug.cgi?id=13402
>
>
> If you want to contribute, please create pull requests on github:
>
>https://github.com/D-Programming-Language
>
> It's doubtful that anyone is going to take your patches and create PR's
for you. So, creating patches and adding them to bugzilla isn't
particularly useful, even if it's good code.
>
> - Jonathan M Davis

Responses like this aren't particularly useful either.  We have a 'patch'
keyword in bugzilla (from memory), and people are free to use that as a
tool to manage bugs raised against D.

In fact, has anyone recently gone through bug tickets with attachments and
checked for patches?  This could be one thing to do for EMSI's monthly bug
squashing event (a similar thing is already done for squashing regressions
or ICE's in the beta releases).

It doesn't take a lot of work to do this.

- Find and appropriately tag any bug reports with patches attached.
- Review the tagged bug reports.
- Mark as 'needs-work' if the patch doesn't apply.
- Mark as 'pull-request' and raise a PR if it applies and fixes the
bug/enhancement.  Use your best judgement when reviewing the code, but
after a PR has been created, it will be properly code reviewed.
- Close if the report is no longer reproducible, or patch has been applied
or rejected (rejected enhancement patch).

And doing that for a couple hours a month is better than telling people not
to send patches to bugzilla because no one will look at it.

If you put this doubt in people's minds, what does that say about the
actual bug reports?  Should I even bother raising a bug report when no one
will look at it?  Maybe I should just instead raise a PR with a test case
and a comment next to the line that ICE's.  People read PRs, so my bug will
be tended to answer fixed sooner.

(I don't actually plan in doing this).

Iain.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puremagic.com/pipermail/digitalmars-d/attachments/20140830/c3116bbb/attachment-0001.html>