More radical ideas about gc and reference counting
Walter Bright via Digitalmars-d
digitalmars-d at puremagic.com
Tue May 6 11:10:11 PDT 2014
On 5/6/2014 10:47 AM, Manu via Digitalmars-d wrote:
> On 7 May 2014 01:46, Andrei Alexandrescu via Digitalmars-d
> I'm not even sure what the process it... if I go through and "LGTM" a
> bunch of pulls, does someone accept my judgement and click the merge
> button?
> You can see why I might not feel qualified to do such a thing?
You don't need to be qualified (although you certainly are) to review PR's. The
process is anyone can review/comment on them. Non-language-changing PR's can be
pulled by anyone on "Team DMD". Language changing PR's need to be approved by
Andrei and I.
"Team DMD" consists of people who have a consistent history of doing solid work
reviewing PR's.
> I'll criticise at least 10 pull requests in the morning. I'll be
> curious to see what happens.
Great!
>>> I can't review the Obj-C patch. 1, it's huge, 2, I don't know anything
>>> about it, other than I'd really like to use D on iOS and that's a
>>> major hurdle.
>>
>>
>> Surely there must be something that should catch your fancy among the
>> remaining 189 patches.
>
> We'll find out... when I wake up.
You don't actually have to understand the entire PR in order to do reviews. You
can do micro reviews like "needs explanatory comment", "this line is bad style",
"this section looks like a buffer overflow", "bad formatting", "don't use
gets()", etc.
More information about the Digitalmars-d
mailing list