std.experimental.logger formal review round 3

Sönke Ludwig via Digitalmars-d digitalmars-d at puremagic.com
Thu Oct 2 12:53:42 PDT 2014


Am 01.10.2014 14:49, schrieb Robert burner Schadek:
> On Wednesday, 1 October 2014 at 10:50:54 UTC, Kevin Lamonte wrote:
>> I haven't tested it yet, but have two questions anyway:
>>
>> 1. I did not see any reference to the use of Clock.currTime(), which
>> on the last round accounted for about 90% of the total time spent in a
>> log call.  Reference: https://issues.dlang.org/show_bug.cgi?id=13433
>> .  (This is the difference between logging-and-filtering ~100k
>> logs/sec and ~1M logs/sec for loggers that use criteria other than
>> logLevel for filtering messages.)  Same question for this cycle:  Does
>> std.logger API need a method for clients or subclasses to
>> change/defer/omit the call to Clock.currTime?  Or defer for a change
>> in std.datetime?
>>
>
> maybe I should add a disableGetSysTime switch

Don't know if this is still the case, but calling Clock.currTime() used 
to allocate on each call, whereas Clock.currTime(UTC()) didn't and thus 
was orders of magnitudes faster.


More information about the Digitalmars-d mailing list