How can I help with pull requests if I don't have the authority to merge?
Jakob Ovrum via Digitalmars-d
digitalmars-d at puremagic.com
Thu Jan 29 11:46:02 PST 2015
On Thursday, 29 January 2015 at 13:42:15 UTC, Atila Neves wrote:
> After this thread:
>
> http://forum.dlang.org/thread/hapxxhusoniimfxiefji@forum.dlang.org
>
> I had some time today and headed over to Github to see if I
> could help out. But I'm not sure what I can do if I don't have
> the power to approve PRs. I'm not asking for that power, I
> haven't earned it yet. I'm just asking what it is I can do to
> help, especially on PRs that already have comments from a bunch
> of people.
Although the Github tags aren't always kept up to date, this link
might be useful when looking for patches that need review:
https://github.com/D-Programming-Language/phobos/labels/needs%20review
> Should I add comments to the ones that don't? Work on my own
> PRs instead?
Well, the ones that don't have any review might benefit more from
you looking over it, but people often miss things; the more
review the merrier. Please comment whenever you feel you have
something to add!
Equally for your own patches, if you feel you have something to
add, whether a bug fix, documentation improvement or new
functionality, please send a PR :)
More information about the Digitalmars-d
mailing list