Phobos addition formal review: std.experimental.allocator

Andrei Alexandrescu via Digitalmars-d digitalmars-d at puremagic.com
Mon Jun 22 15:38:26 PDT 2015


On 6/22/15 2:40 PM, Dicebot wrote:
> On Monday, 22 June 2015 at 19:51:50 UTC, Andrei Alexandrescu wrote:
>>> 2. `IAllocator` is defined inside `package.d` file. That means that it
>>> is impossible to use interface without import ALL of allocator modules
>>
>> Fixed, now interested users need to import
>> std.experimental.allocator.building_blocks.
>>
>>> 3. Same concern is about
>>> https://github.com/andralex/phobos/blob/allocator/std/experimental/allocator/package.d#L218-L228
>>>
>>> - unless you actually import all stuff via package.d, those configured
>>> allocators are not available.
>>
>> Fixed per above.
>
> Is it? I still see those symbols defined in package.d ,
> 14ccc3a02f3dd332cb435abaf3c35cb8847797c0 does not seem to have affected
> that.

Perhaps I misunderstood the request - currently the imports in 
allocator/package.d are:

public import std.experimental.allocator.common,
     std.experimental.allocator.typed;
import std.algorithm, std.conv, std.exception, std.range, std.traits,
     std.typecons, std.typetuple;
version(unittest) import std.random, std.stdio;

Is that okay, and if not what should change?


Andrei



More information about the Digitalmars-d mailing list