New adapter: std.allocator.quantizer

Andrei Alexandrescu via Digitalmars-d digitalmars-d at puremagic.com
Mon May 11 11:48:33 PDT 2015


On 5/11/15 11:31 AM, Timon Gehr wrote:
> - The assertion in line 141 may fail. (expand can return false.)

OK, it seems the previous commit should take care of that.

>    (Rant: Go on, conflate assert and assume in -release and then, when a
> sufficiently smart optimizer runs, suddenly expand will always return
> true and user code that checks for success of expand will be removed.
> Awesome.)

Well I do find it awesome actually...

> - 'expand' ought to call 'allocate' when passed an empty buffer in case
> the parent does not define 'expand', no?

Yah, in fact it suffices to call allocate() whether or not the parent 
defines expand(). So I did so in 
https://github.com/andralex/phobos/commit/9307b9f8969b7bfd0906e0441a13cbbded7f8418.


Andrei


More information about the Digitalmars-d mailing list