Automatically enforce Phobos's styleguide

Seb via Digitalmars-d digitalmars-d at puremagic.com
Tue Apr 26 18:36:02 PDT 2016


On Tuesday, 26 April 2016 at 19:04:44 UTC, Seb wrote:
> Hey all,
>
> tl;dr: I want to pull improve Phobos code style for the greater 
> good of having a bot that automatically checks the coding 
> style. This should be quite useful for submitters. I hope we 
> all agree that the time spent "nitpicking" is wasted, we 
> overlook much (see below) and we can do better!
>
> Agenda
> ------
>
> The idea is quite simple:
> 1) Fix one violation for the entire codebase
> 2) Enable it in the bot.
> 3) Pick next violation and goto 1)

Great news:
1) I submitted a couple of trivial fixes (#4245, #4246, #4247)
2) The Travis bot passes :)

As mentioned I decreased the linting to a minimum, but now we do 
have it :)
Future work can fix more violations in the Phobos codebase - 
small low hanging fruits include e.g. > 120 lines or undocumented 
public methods.

For more details:
https://github.com/dlang/phobos/pull/4243


More information about the Digitalmars-d mailing list