Anyone has time for a unittesting issue?

Andrei Alexandrescu via Digitalmars-d digitalmars-d at puremagic.com
Sun Oct 2 09:26:03 PDT 2016


On 10/02/2016 09:19 AM, Joakim wrote:
> On Sunday, 2 October 2016 at 01:30:15 UTC, Vladimir Panteleev wrote:
>> On Sunday, 2 October 2016 at 01:23:18 UTC, Andrei Alexandrescu wrote:
>>> There, we list the full content of /tmp, recursively. That's not
>>> quite the right thing to do. Not only the run time is arbitrarily
>>> slow, but the test may file if certain subdirs are inaccessible.
>>> Vladimir, maybe I can convince you to find a better solution for
>>> that, too? :o)
>>>
>>> https://issues.dlang.org/show_bug.cgi?id=16571
>>
>> The unittest in question is ensuring that compilation succeeds:
>>
>> https://github.com/dlang/phobos/pull/3821
>>
>> Solution: move the dirEntries call inside the __traits(compiles) check.
>>
>> I'm doing server maintenance tonight so no PR for the moment :)
>
> This is partly my fault:
>
> https://github.com/dlang/phobos/pull/4332/files#diff-52580fb75b304ba7b04a6b178fe6cdf4L3270
>
>
> I'll submit a PR with the fix you suggest.

Thanks! -- Andrei


More information about the Digitalmars-d mailing list