DIP 1006 - Preliminary Review Round 1

[Mathias Lang via Digitalmars-d]

On Wednesday, 12 April 2017 at 11:32:37 UTC, rikki cattermole 
wrote:
> On 12/04/2017 12:25 PM, Mike Parker wrote:
>> DIP 1006 is titled "Providing more selective control over 
>> contracts".
>>
>> https://github.com/dlang/DIPs/blob/master/DIPs/DIP1006.md
>>
>> All review-related feedback on and discussion of the DIP 
>> should occur in
>> this thread. The review period will end at 11:59 PM ET on 
>> April 26 (3:59
>> AM GMT), or when I make a post declaring it complete.
>>
>> At the end of Round 1, if further review is deemed necessary, 
>> the DIP
>> will be scheduled for another round. Otherwise, it will be 
>> queued for
>> the formal review and evaluation by the language authors.
>>
>> Thanks in advance to all who participate.
>>
>> Destroy!
>
> How exactly does this affect unittests?
> From what I can see, in none mode unittests won't have any 
> asserts, which is clearly a problem.

Good point.
I would say that `-contracts=none` and `-unittest` should behave 
the same as `-release` and `-unittest`, and currently it only 
turns asserts on ( 
https://github.com/dlang/dmd/blob/ac3225a025b578d45ff39a40dda35006fb455a37/src/ddmd/mars.d#L1100-L1109 ).
I'll add a note about it in the DIP.