3 months of waiting...
Petar
Petar
Thu Feb 6 22:53:19 UTC 2020
On Thursday, 6 February 2020 at 16:26:43 UTC, berni44 wrote:
> Last week, I was quite disappointed when no one replied on my
> anouncement of a new website about D (meanwhile there are three
> replies, one negative, two positive, but it's somewhat too
> late). I'm also waiting for almost three months now for a
> review of my PRs concerning replacing sprintf (just doing
> thumbs up isn't enough). Together this made me quite sad.
>
> So I decided to stay away for a week to calm down and to have
> time to think about this. Finally I came to the conclusion,
> that I do not fit in this community. So I will leave.
>
> I kept all PRs open, because I think they are all ripe to be
> merged (there is one, where n8sh commented in the last week and
> his suggestions should be added), but I will neither care for
> them anymore. Close them, use them or continue to ignore them;
> I don't mind.
>
> Recently I was working on a complete rewrite of the
> documentation of std.format with some improvements, bug fixes
> and stuff. I added also unittests to verify the documentation.
> It's still work in progress, but it's about 80% finished. Again
> I will not continue work on this. But I uploaded it on github
> [1]. You can use it, if you like.
>
> Bye bye
>
> [1] https://github.com/berni44/phobos/blob/formatS/std/format.d
Hello Bernie,
From what I have seen you have been doing an excellent job and
your skills and dedication would be missed. I really hope you
would reconsider. You can be sure that the problem is not with
you, nor that you "do not fit in the community", but just the
lack of people with sufficient time and experience to review your
work at a given moment.
From my observation it's really periods of high followed by low
concentration of activity and responsiveness on GitHub. Sometimes
you can be lucky and have stuff merged within hours or even
minutes and sometimes it may take days, weeks, or even months.
The only recipe for getting things in is:
- splitting your work on as small as possible chunks, so it can
be reviewed more easily
- persistence
- pushing people from time to time ;)
- not taking things personal
even if no one chimes in on a PR of yours for long time, it's not
because they don't like you or they don't think your work is
important. It's most likely because no one was available at that
time and unfortunately after a while PRs go under the radar if
they stay without activity for a while. If that happens just ping
people to remind them and eventually things will turn around.
I hope in the future we can do a better job as a community of
respective contributors' time.
Thank you for your efforts, focus and persistence. I hope to see
you around again!
All the best,
Petar
More information about the Digitalmars-d
mailing list