[Dlang-internal] Separate compilation identifier mess and the bug trail that ensued

[kinke]

On Thursday, 26 July 2018 at 09:09:07 UTC, Atila Neves wrote:
> If I do it during semantic analysis it would be easy: keep a 
> counter per module.

Ah, I thought you wanted to go further (identical names, 
independent of defined versions for compiler invokation etc.). I 
looked at a PR of yours, where you changed back from finalizing 
the identifier in semantic, assuming that it already was like 
that originally, but I now see that you moved it to semantic 
shortly before. ;)

So if it has to be done before semantic and we have no clue about 
the D module at that time, can't we use a counter per Loc 
(filename, line, column)? Only creating one if there's a 
unittest/invariant/... declaration to be uniquely named of 
course, to keep the number of counters reasonably small.