[dmd-internals] [D-Programming-Language/dmd] 10640a: dang, forgot that one, too

[Leandro Lucarella]

Jonathan M Davis, el  7 de November a las 04:07 me escribiste:
> On Wednesday, November 07, 2012 12:38:49 Leandro Lucarella wrote:
> > Walter Bright, el  6 de November a las 22:12 me escribiste:
> > > On 11/6/2012 9:04 PM, Brad Roberts wrote:
> > > >On 11/6/2012 7:44 PM, Walter Bright wrote:
> > > >>I do run the test suite locally before committing.
> > > >
> > > >On all platforms?  On the code you _actually_ committed not vs what you
> > > >have in some other client?
> > > >
> > > >Based on the frequency of omitting a file and/or seeing a broken build,
> > > >the answer to both of those is all too often 'no'.  Both of which would
> > > >be true if you followed the pull + merge model that everyone else
> > > >follows.> 
> > > I run it on all the platforms but FreeBSD64 and then copy the files
> > > to the git repository on Linux.
> > 
> > That clearly doesn't detect errors when you forgot to commit stuff. Is NOT
> > the same as going through the autotester which compiles everything from a
> > fresh checkout.
> 
> Well, there are really 2 problems here.
> 
> 1. Copying files across rather than using git on Windows.
> 
> 2. Committing directly instead of creating pull requests and letting the pull 
> tester test them.

Yes, but 1. is about Walter's personal life and 2. is a D problem. If Walter
think is better for him to copy files around, fine with me, as long as he
doesn't break the repository. That's why I'm concentrating in 2. Follow the
rules as everybody else to minimize the occurrence of these kind of errors.

--