[phobos] phobos commit, revision 1877
David Simcha
dsimcha at gmail.com
Tue Aug 17 06:26:49 PDT 2010
Great. I'll stress test this (i.e. test it in ways that would not be
feasible to include in a unittest, such as with an actual 5GB file)
tonight. Right now I don't have time. I'll let you know how it goes.
On 8/17/2010 3:09 AM, Andrei Alexandrescu wrote:
> Steve Schveighoffer wrote:
>> This is wrong on two counts.
>>
>> First, david is right, changing from long to ulong is a mistake.
>> long is correct, this supports 2^63 bytes, which is plenty larger
>> than the current 2GB limitation, and it allows negative seeking
>> without issue.
>
> Good point. Fixed.
>
>> Second, you cannot do a tell on the file handle, because you need to
>> take into account the buffer.
>
> My understanding is that calling fflush() before lseek should be fine.
> See my upcoming commit.
>
>
> Andrei
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
>
More information about the phobos
mailing list