[phobos] CustomFloat

[David Simcha]

I can see your point, though I don't see this as a very risky change 
given that:

1.  It's in a non-critical module of Phobos.
2.  Its main purpose is to fix something that's horribly broken right now.

On 6/9/2010 10:55 PM, Brad Roberts wrote:
> At this point, between the beta and the public release, I think we should
> consider all three packages frozen except for critical fixes.
>
> So, please hold this one for after the release is out.
>
> My 2 cents,
> Brad
>
> On 6/9/2010 7:29 PM, David Simcha wrote:
>    
>> I can't reproduce this at all.  At any rate, I'm going to check this in
>> because there were no other issues, I want to get it in for 2.047, and
>> it's a HUGE improvement over what was there before even if it's not
>> perfect.  If you can give some hints on how to reproduce this, please
>> let me know.
>>
>> On 6/8/2010 4:04 AM, Lars Tandle Kyllingstad wrote:
>>      
>>> On Sat, 2010-06-05 at 10:42 -0400, David Simcha wrote:
>>>
>>>        
>>>> Robert Jacques (who I know offline and, in fact, was the person who
>>>> introduced me to D) has massively improved/debugged CustomFloat and
>>>> asked me to post it for review and commit it to Phobos.  See the
>>>> attached file.  If everyone's happy with it, I'll replace the current
>>>> impl in std.numeric and check it in.
>>>>
>>>>          
>>> It's awesome that someone's working on this -- I've seen people
>>> complaining about the state of CustomFloat several times.  (I think the
>>> last time was when we discussed the possibility of using an 80-bit
>>> CustomFloat in Masahiro's msgpack library, to wrap 80-bit reals on
>>> systems that don't support them.)
>>>
>>> That said, I'm having some problems with it.  Looking at the code and
>>> documentation, the following should be correct usage:
>>>
>>>           alias CustomFloat!16 float16;
>>>
>>> However, compiling it with DMD 2.046, I get the errors
>>>
>>>           customfloat.d(430): Error: template instance ToBinary!(real)
>>>           does not match template declaration ToBinary(F) if
>>>           (is(CustomFloat!(F.sizeof * 8)))
>>>           customfloat.d(430): Error: ToBinary!(real) is used as a type
>>>           ...
>>>
>>> -Lars
>>>
>>> _______________________________________________
>>> phobos mailing list
>>> phobos at puremagic.com
>>> http://lists.puremagic.com/mailman/listinfo/phobos
>>>
>>>
>>>        
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos
>>      
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
>
>