[phobos] Proposed feature: print cycle when a module cyclic dependency is detected

[Steve Schveighoffer]

Hi all,

Recently, I had an issue when developing std.process.  I inadvertently caused a cyclic dependency in modules.  However, the error was not enough to find the problem:

object.Exception: Cyclic dependency in module std.stdio

The problem is, this is the *end* of the cycle, not the source.  I actually hadn't changed the imports of std.stdio.

So I improved the module constructor function to automatically print all modules involved in the cycle, in the order they were imported.  Attached is the patch.  The function should not adversely affect the runtime in normal operation, since the changes I made only occur when a terminating exception is about to be thrown anyways.  Do people agree this is a worthy improvement to the runtime?  Anyone see any issues with the patch? If everyone likes, I'll commit.

-Steve



      
-------------- next part --------------
A non-text attachment was scrubbed...
Name: printcycles.patch
Type: application/octet-stream
Size: 1825 bytes
Desc: not available
URL: <http://lists.puremagic.com/pipermail/phobos/attachments/20100622/5997eb8d/attachment.obj>