[phobos] phobos commit, revision 1689

[Sean Kelly]

All a matter of opinion, but I'd say that @property should only be applied to logical properties of the data structure (go figure).  A clone method (ie. save) doesn't represent an attribute of the data, it's simply a non-mutating operation on the data.  An easy litmus test is whether the member could be replaced with a public variable.  If so, it's probably a property.  This is the real purpose of the no-parens syntax anyway--it allows the class designer to replace public data members with functions at no cost to the end user.

On Jun 23, 2010, at 7:45 AM, Andrei Alexandrescu wrote:

> I think it should be a property. I followed the convention that stuff that doesn't change "this" is a property.
> 
> Andrei
> 
> On 06/23/2010 09:01 AM, David Simcha wrote:
>> Isn't that the point of @property?  I just followed what Andrei was
>> doing.  If there's anywhere where I didn't put @property in, it's purely
>> an unintentional oversight.  Please let me know and/or fix it.
>> 
>> On Wed, Jun 23, 2010 at 9:34 AM, Max Samukha <maxsamukha at gmail.com
>> <mailto:maxsamukha at gmail.com>> wrote:
>> 
>> 
>> 
>>    On Wed, Jun 23, 2010 at 4:07 PM, dsource.org <http://dsource.org>
>>    <noreply at dsource.org <mailto:noreply at dsource.org>> wrote:
>> 
>>        phobos commit, revision 1689
>> 
>> 
>>        user: dsimcha
>> 
>> 
>>    save() is sometimes attributed with @property, other times it is
>>    not. Is it really a property? I don't think it is a good idea to tag
>>    every function with @property just to make it callable without ().
>> 
>>    _______________________________________________
>>    phobos mailing list
>>    phobos at puremagic.com <mailto:phobos at puremagic.com>
>>    http://lists.puremagic.com/mailman/listinfo/phobos
>> 
>> 
>> 
>> 
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos