[phobos] phobos commit, revision 1553

[Andrei Alexandrescu]

I suspected it's a one-off kind of thing. Thanks, Don.

(Of course that doesn't diminish the value of being careful about 
checking in.)

One more thing - at some point while browsing the commits I saw a 
copyright notice with someone's name. I forgot who it was. It was added 
as the only named copyright notice on an existing module that didn't 
previously have one. The way the commit looked, it was as if that one 
author put his copyright on the entire module, including the existing 
stuff and his added stuff. In such cases the adder should also add the 
copyright notices of the previous known contributors to the file (to be 
found as @author tags, most of the time it's Walter and sometimes it's 
him and others such as Don, Sean, myself, and others) so we all share 
the blame.


Thanks,

Andrei

On 05/25/2010 09:45 AM, Don Clugston wrote:
> On 25 May 2010 16:30, Lars Tandle Kyllingstad<lars at kyllingen.net>  wrote:
>> On Tue, 2010-05-25 at 07:21 -0700, Steve Schveighoffer wrote:
>>>
>>> ----- Original Message ----
>>> [snip]
>>>
>>>> It's great to have so many people contribute to Phobos,
>>>> but I've never had such a long streak of non-builds. It looks like new scale of
>>>> contribution asks for corresponding responsibility. Please, make sure everything
>>>> builds before checking in, and announce to this list if you broke the build and
>>>> are unable to fix it without help.
>>>
>>> I understand your frustration, but it might be unreasonable to ask people to ensure a build occurs properly on all OSes before checking in, this might not be practical (disclaimer: I haven't tried building the latest, maybe the build doesn't work anywhere :)
>
> This is a build which doesn't work anywhere. In this particular
> instance, DMD and Phobos must be synchronized; this always happens
> when changes to intrinsics occur.
>
> It's possible to have a successful build, check in your Phobos
> changes, but have a DMD change in the meantime which causes it to
> break.
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos