[phobos] datetime review

[David Simcha]

Yes, please do.  I don't plan on reviewing datetime in detail because I
don't know much about the more complex use cases for it (the stuff that
makes the design nontrivial), but I'd like to look at the public API in a
way that makes the forest easily visible through the trees and see whether
the simple things that I would use it for are sufficiently simple.

On Sat, Oct 9, 2010 at 8:15 PM, Andrei Alexandrescu <andrei at erdani.com>wrote:

> I suggest you generate html documentation and attach it. I can put it on my
> website.
>
> Andrei
>
>
> On 10/8/10 19:01 CDT, Jonathan M Davis wrote:
>
>> I should probably add that the seven modules aren't exactly equal in size.
>> In
>> particular datetime.all only has its module documentation and public
>> imports for
>> all of the other modules, and datetime.other is quite small. I didn't
>> necessarily split the code into modules in the best manner. I split it
>> more on
>> concepts than the amount of code in them (so datetime.timepoint probably
>> has
>> close to half of the code in it). I'm open to suggestions if someone has a
>> better way to split the code up. Ideally, it would all be in one module,
>> but it
>> was too much for one.
>>
>> Also, as much as there is, a large portion of it is unit tests and
>> documentation. There's definitely more unit tests than normal code, and
>> there
>> might be more documentation than normal code.
>>
>> One point that may need to be improved is the module documentation so that
>> it's
>> more obvious exactly what you need to just get the time and print it out
>> or
>> whatever the insanely simple operations are that would be typical in your
>> average program that does little with the time. I am afraid that it is a
>> bit
>> like std.algorithm in that it's quite easy to use but a bit overwhelming
>> to look
>> at so that you _think_ that it's hard to use, even though it really isn't.
>> I do
>> have quite a few examples it the code though, and I hope that the
>> documentation
>> is generally clear enough. I tried to make it so that it was, but it
>> really
>> needs to have people who aren't familiar with it judge it at this point.
>>
>> - Jonathan M Davis
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos
>>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puremagic.com/pipermail/phobos/attachments/20101009/76fe17a7/attachment.html>