[phobos] phobos commit, revision 2028

Jonathan M Davis jmdavisProg at gmx.com
Mon Sep 20 18:33:09 PDT 2010


On Monday, September 20, 2010 18:23:31 Don Clugston wrote:
> I agree.
> For a large chunk of the past six weeks, unit tests were broken on
> Windows. Situations where tests have passed on Windows but failed on
> *nix have been quite rare. And there are still unit tests which are
> disabled in Windows because they fail, even though they pass on *nix.
> (From memory, there are about five of them).
> IMHO, the main problem was simply been that unit tests were not being
> run at all.


I'm not sure that it's necessarily something that we'd want to do, but would it 
be possible to make it so that checkins which break unit tests not be accepted? 
My guess would be that you can't, and it could be quite annoying to never be 
able to checkin something that breaks unit tests (much as you usually wouldn't 
want to - but it would make sure that the unit tests don't break.

- Jonathan M Davis


More information about the phobos mailing list