[phobos] Push or pull?

Lars Tandle Kyllingstad lars at kyllingen.net
Thu Feb 3 09:25:38 PST 2011


On Thu, 2011-02-03 at 10:54 -0600, Andrei Alexandrescu wrote:
> Lars, you seem to know your way around the process. Do you think you 
> could put together a short document and a collection of scripts that 
> people can use? The workflows involved are:
> 
> 1. I am done making a change and want to submit it for review.
> 
> 2. Reviewers gave feedback and I need to change my stuff and submit it 
> back for review. Preferably there would be an obvious connection between 
> the first and subsequent submissions.
> 
> 3. Reviewers are okay with my changes, I need to upload them.

Sure, I can write a "contributor's guide". :)  I don't know how much we
can do with scripts, though.  A lot of the process is just point'n-click
on GitHub.


> Ideally we'd have a means of enforcement, i.e. no code makes it that 
> didn't get "OK" at least from one reviewer. Also, even if one reviewer 
> gave "OK" another one could veto.
> 
> We use a similar process at Facebook and it is extremely helpful.

I'll check whether GitHub supports anything like that.

-Lars



More information about the phobos mailing list