[phobos] phobos commit, revision 2309

[Brad Roberts]

On Tue, 11 Jan 2011, Walter Bright wrote:

> Brad Roberts wrote:
> > 
> > Thanks.. sorry for being abrupt.
> >   
> 
> No prob. I have a very thick skin!
> 
> > Also, it looks like the alignment changes to dmd have broken at least one of
> > the tests (just judging from the failure output):
> > 
> > core.exception.AssertError at template1(1480): Assertion failure
> > 
> > I'm pretty sure it won't be the only failure.
> > 
> >   
> 
> The previous alignment clearly was broken. zlib wouldn't interact with its C
> implementation with it.

I understand _why_ it was changed and _why_ the tests are failing.  That's 
not the point.  The point is that the tests are failing and need to be 
fixed as a part of fixing the bug.  Leaving the tests broken means you've 
left half the job incomplete.

Grumpy still,
Brad