[phobos] lots of spurious code that doesn't work

Andrei Alexandrescu andrei at erdani.com
Fri Jan 21 18:42:16 PST 2011


After having updated there are reams of code that doesn't work. There 
are a few issues that I think we need to be careful of:

* There are absolutely huge wads of code versioned under D_ddoc, that 
has rotten and prevents documentation generation. This means code was 
committed without compiling. Please compile all code with the relevant 
flags before committing.

* We already have version=ddoc in posix.mak for documentation. Is D_Ddoc 
predefined somewhere? In

* Walter and I have very different styles but generally are trying to 
make every line of Phobos count. I have no doubt examples can be found 
to the contrary, but please let's stop this trend of verboseness like:

@property string name() const
{
   assert(0, "No implementation. Function exists only for DDoc generation");
}

Just don't define the function! There are many examples. Whenever 
inserting a line of code, please ask yourself what amount of work that 
line does.

I'll try to fix things now.


Thanks,

Andrei


More information about the phobos mailing list