[phobos] Please stop merging pull requests
Jonathan M Davis
jmdavisProg at gmx.com
Tue Sep 6 00:23:53 PDT 2011
On Tuesday, September 06, 2011 09:18:46 Don Clugston wrote:
> On 6 September 2011 08:27, Walter Bright <walter at digitalmars.com> wrote:
> > unless they are fixing regressions in the beta.
> >
> > The last time I did a pull to add in the changes to std.parallelism, it
> > pulled in a bunch of other stuff that broke peoples' code in the beta.
> > We
> > will never get the release done by doing things this way.
> >
> > The current beta breaks are:
> >
> > http://d.puremagic.com/issues/show_bug.cgi?id=6606
> >
> > and Sönke Ludwig's problem with DLLs that probably resulted from a
> > change in druntime.
> >
> > Please, no more merging other than fixing these two issues.
>
> This is another pull request which shouldn't have been folded in. But
> it's probably harmless, don't know if we need to revert it or not.
> https://github.com/D-Programming-Language/druntime/commit/42495b8c76f1018132
> 620a6128d40f170c782050 _______________________________________________
That commit seems utterly pointless. The function doesn't have any code in it.
True, it won't break anything to leave it in, but it certainly seems to me
that we should revert it.
- Jonathan M Davis
More information about the phobos
mailing list