[phobos] std.log ready for review!
Jose Armando Garcia
jsancio at gmail.com
Sun Feb 12 18:30:08 PST 2012
On Sat, Feb 11, 2012 at 3:33 AM, David Nadlinger <code at klickverbot.at> wrote:
> Okay, seems like we have an abundance of modules ready to review, but are
> lacking review managers. Given that the Thrift/D code is submitted for
> upstream inclusion and its to-do list is currently empty, I'd be happy to
> help out – but which module do we want to review first? std.log has been in
> the queue forever (but was previously postponed due to Jose being
> unavailable), std.uuid is small (but parts of it depend on not-yet-in-Phobos
> hashing code), and Jacob Carlborg is waiting for feedback on Orange…
>
> David
Okay David,
std.log is good to go...
Source code: https://github.com/jsancio/phobos/commit/d114420e0791c704f6899d81a0293cbd3cc8e6f5
HTML doc: http://jsancio.github.com/phobos/phobos/std_log.html#minSeverity
Thanks,
-Jose
>
>
>
> On 2/9/12 3:31 AM, Andrei Alexandrescu wrote:
>>
>> Who would want to be the review manager for this and UUID?
>>
>> Andrei
>>
>> On 2/7/12 5:02 AM, Jose Armando Garcia wrote:
>>>
>>> Hey all,
>>>
>>> The module std.log is finally ready for review. I would like to put it
>>> in the review queue for phobos. Here are some links for your
>>> documentation:
>>>
>>> 1. HTML Documentation:
>>> http://jsancio.github.com/phobos/phobos/std_log.html
>>> 2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d
>>>
>>> The module should work as is with the latest druntime. I would really
>>> appreciate it if you can try it and comment on the implementation.
>>>
>>> Thanks,
>>> -Jose
>>> PS. It has been a while since I tested it in Windows but it should
>>> work. I am going to spend some time validating that OS.
>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
More information about the phobos
mailing list