[phobos] Friendly reminder about pull requests
Andrei Alexandrescu
andrei at erdani.com
Sun Jul 1 19:18:44 PDT 2012
One issue I'm having with reviewing: I can't seem to find a place to see
the latest and greatest proposed code diff'ed against the extant code.
Is there a possibility to do that? I can only see stuff changed by each
individual diff, which is fine if I look for a specific change, but what
I really want to review is everything proposed against everything current.
Thanks,
Andrei
On 7/1/12 9:35 PM, Jonathan M Davis wrote:
> Just a friendly reminder that those of us with commit access to Phobos should
> be reviewing pull requests at least periodically. All pull requests are
> supposed to be reviewed by at least one Phobos dev (and preferrably at least
> one Phobos dev who didn't actually create the request).
>
> I know that we're all busy (and some of us are extremely busy), but if no one
> is reviewing pull requests and merging them, then pull requests will just sit
> there and good work will be wasted (and those who submit them may be
> discouraged about making further submissions). So, please try and review pull
> requests at least once in a while, if not regularly.
>
> - Jonathan M Davis
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
More information about the phobos
mailing list